feat: add `blas/ext/base/dnancusumpw` by MeKaustubh07 · Pull Request #10402 · stdlib-js/stdlib

MeKaustubh07 · 2026-02-21T14:00:24Z

Resolves #314 .

Description

What is the purpose of this pull request?

This pull request:

feat: add blas/ext/base/dnancusumpw

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

RFC: add blas/ext/base/dnancusumpw #314

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

stdlib-bot · 2026-02-21T14:03:40Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/dnancusumpw	$\color{green}429/429$ $\color{green}+0.00%$	$\color{green}22/22$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{green}429/429$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

gururaj1512 · 2026-03-05T15:52:17Z

+* var N = x.length;
+*
+* var v = dnancusumpw( N, 0.0, x, 1, y, 1 );


Suggested change

* var N = x.length;

*

* var v = dnancusumpw( N, 0.0, x, 1, y, 1 );

*

* var v = dnancusumpw( x.length, 0.0, x, 1, y, 1 );

gururaj1512 · 2026-03-07T06:26:08Z

+	]);
+	N = 3;


Suggested change

]);

N = 3;

]);

gururaj1512 · 2026-03-07T06:26:16Z

+	var expected;
+	var x;
+	var y;
+	var N;


Suggested change

var N;

gururaj1512 · 2026-03-07T06:26:33Z

+	]);
+	N = 3;
+
+	dnancusumpw( N, 0.0, x, 2, y, 1 );


Suggested change

dnancusumpw( N, 0.0, x, 2, y, 1 );

dnancusumpw( 3, 0.0, x, 2, y, 1 );

gururaj1512 · 2026-03-07T06:26:49Z

+	var expected;
+	var x;
+	var y;
+	var N;


Suggested change

var N;

gururaj1512 · 2026-03-07T06:26:57Z

+		0.0,
+		0.0  // 2
+	]);
+	N = 3;


Suggested change

N = 3;

gururaj1512 · 2026-03-07T06:27:04Z

+	]);
+	N = 3;
+
+	dnancusumpw( N, 0.0, x, 1, y, 2 );


Suggested change

dnancusumpw( N, 0.0, x, 1, y, 2 );

dnancusumpw( 3, 0.0, x, 1, y, 2 );

gururaj1512 · 2026-03-07T06:27:16Z

+	var expected;
+	var x;
+	var y;
+	var N;


Suggested change

var N;

gururaj1512 · 2026-03-07T06:27:23Z

+		0.0,
+		0.0
+	]);
+	N = 3;


Suggested change

N = 3;

gururaj1512 · 2026-03-07T06:27:33Z

+	]);
+	N = 3;
+
+	dnancusumpw( N, 0.0, x, -2, y, -1 );


Suggested change

dnancusumpw( N, 0.0, x, -2, y, -1 );

dnancusumpw( 3, 0.0, x, -2, y, -1 );

gururaj1512 · 2026-03-07T06:27:58Z

+	var expected;
+	var x;
+	var y;
+	var N;


Suggested change

var N;

gururaj1512 · 2026-03-07T06:28:05Z

+		0.0,
+		0.0
+	]);
+	N = 3;


Suggested change

N = 3;

gururaj1512 · 2026-03-07T06:28:18Z

+	]);
+	N = 3;
+
+	dnancusumpw( N, 0.0, x, 2, y, -1 );


Suggested change

dnancusumpw( N, 0.0, x, 2, y, -1 );

dnancusumpw( 3, 0.0, x, 2, y, -1 );

gururaj1512 · 2026-03-07T06:29:37Z

+	var y0;
+	var x1;
+	var y1;
+	var N;


Suggested change

var N;

gururaj1512 · 2026-03-07T06:29:46Z

+	x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // begin at 2nd element
+	y1 = new Float64Array( y0.buffer, y0.BYTES_PER_ELEMENT*3 ); // begin at the 4th element
+
+	N = 3;


Suggested change

N = 3;

gururaj1512 · 2026-03-07T06:29:57Z

+
+	N = 3;
+
+	dnancusumpw( N, 0.0, x1, -2, y1, 1 );


Suggested change

dnancusumpw( N, 0.0, x1, -2, y1, 1 );

dnancusumpw( 3, 0.0, x1, -2, y1, 1 );

gururaj1512 · 2026-03-07T06:33:11Z

Changes similar to these needs to be reflected in all tests files

gururaj1512 · 2026-03-07T06:44:23Z

+
+<!-- /.c -->
+
+


Suggested change

gururaj1512

LGTM

feat: add blas/ext/base/dnancusumpw

7abbcb9

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Feb 21, 2026

fix paths and spaces

768ade4

gururaj1512 reviewed Mar 5, 2026

View reviewed changes

MeKaustubh07 marked this pull request as draft March 5, 2026 16:27

gururaj1512 reviewed Mar 7, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/blas/ext/base/dnancusumpw/README.md Outdated



Copy link
Copy Markdown

Member

gururaj1512 Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

gururaj1512 requested changes Mar 7, 2026

View reviewed changes

MeKaustubh07 added 2 commits March 8, 2026 22:46

add suggested changes

061b85a

lint

e9280c8

MeKaustubh07 marked this pull request as ready for review March 8, 2026 18:39

gururaj1512 previously approved these changes Mar 9, 2026

View reviewed changes

chore: cleanup

3270c9a

MeKaustubh07 dismissed gururaj1512’s stale review via 3270c9a March 9, 2026 20:07

	dnancusumpw( N, 0.0, x, 2, y, 1 );
	dnancusumpw( 3, 0.0, x, 2, y, 1 );

+.0,
+.0  // 2
+              	]);
+              	N = 3;

	dnancusumpw( N, 0.0, x, 1, y, 2 );
	dnancusumpw( 3, 0.0, x, 1, y, 2 );

+.0,
+.0
+              	]);
+              	N = 3;

	dnancusumpw( N, 0.0, x, -2, y, -1 );
	dnancusumpw( 3, 0.0, x, -2, y, -1 );

	dnancusumpw( N, 0.0, x, 2, y, -1 );
	dnancusumpw( 3, 0.0, x, 2, y, -1 );

	dnancusumpw( N, 0.0, x1, -2, y1, 1 );
	dnancusumpw( 3, 0.0, x1, -2, y1, 1 );

Uh oh!

Conversation

MeKaustubh07 commented Feb 21, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gururaj1512 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Feb 21, 2026 •

edited

Loading